Skip to content

fix(observability): remove invalid fields match and match_regex from main route in alert_config #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(observability): remove invalid fields match and match_regex from main route in alert_config #915

wants to merge 1 commit into from

Conversation

marceljk
Copy link
Contributor

@marceljk marceljk commented Jul 17, 2025 •
edited
Loading

Description

relates to STACKITTPR-226 and #784

  • removed invalid fields match and match_regex from main route in alert_config
  • deprecated match and match_regex in child routes
  • add new matchers field

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk force-pushed the fix/STACKITTPR-226-observability-creation-with-matchers-fails branch from 078d4fd to 0ebcb10 Compare July 28, 2025 07:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2025

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Aug 5, 2025
@marceljk
fix: remove invalid match and match_regex from main route in aler…
45f2347 
…t_config

- deprecated `match` and `match_regex` in child routes
- add new `matchers` field
@marceljk marceljk force-pushed the fix/STACKITTPR-226-observability-creation-with-matchers-fails branch from 0ebcb10 to 45f2347 Compare August 5, 2025 07:06
@marceljk marceljk removed the Stale PR is marked as stale due to inactivity. label Aug 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2025

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance 39.20% (-0.06%) 👎
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/datasource.go 0.00% (ø) 72 0 72
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/resource.go 42.62% (-0.21%) 826 (+32) 352 (+12) 474 (+20) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/resource_test.go

@github-actions GitHub Actions
Copy link

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Aug 13, 2025
@haeussermanp haeussermanp mentioned this pull request Aug 13, 2025
Open
@haeussermanp
Copy link

Hi, why is it on hold? Just a new comment so it would not be removed. 😄

@Fyusel Fyusel removed the Stale PR is marked as stale due to inactivity. label Aug 13, 2025
@marceljk
Copy link
Contributor Author

Hi, why is it on hold? Just a new comment so it would not be removed. 😄

Hi @haeussermanp, there is an API issue the set matchers doesn't return on a GET request. This results in an error in the terraform provider.
This issue is already reported to the Observability Team.

When this is fixed, the PR is ready for review 😄

@github-actions GitHub Actions
Copy link

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Aug 22, 2025
@marceljk marceljk removed the Stale PR is marked as stale due to inactivity. label Aug 25, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2025

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Sep 2, 2025
@marceljk marceljk removed the Stale PR is marked as stale due to inactivity. label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on-hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marceljk @haeussermanp @Fyusel @rubenhoenle